-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1818021 - Implement observedDigest #842
Conversation
src/app/plan/duck/sagas.ts
Outdated
if (isRerunPVDiscovery) { | ||
const updatedGeneration = updatedPlan.status.observedDigest; | ||
const oldGeneration = currentPlan.status.observedDigest; | ||
if (updatedGeneration === oldGeneration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update each of these return paths with a comment that describes the specific case?
4dca6fa
to
6feb51e
Compare
I've tested this on 3->3 and 3->4 migrations and had good success with both, this even repairs a number of edit problems we've had previously: Really happy to see this come together, thank you @ibolton336! Want to follow up on the comments because I'm having a hard time following but I think this is looking good. |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1818021
Closes #781