Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom ports for the backend service of an Ingress path. Support exposing multiple ports under different paths. #120

Closed
HarikrishnanBalagopal opened this issue Oct 26, 2020 · 1 comment · Fixed by #115, #195 or #205
Closed

Support custom ports for the backend service of an Ingress path. Support exposing multiple ports under different paths. #120

HarikrishnanBalagopal opened this issue Oct 26, 2020 · 1 comment · Fixed by #115, #195 or #205
Assignees
@HarikrishnanBalagopal
Labels
backlog
Projects
Move2Kube Move2Kube

Comments

@HarikrishnanBalagopal
Copy link
Contributor

HarikrishnanBalagopal commented Oct 26, 2020 •
edited
Loading

Right now we always set the backend service port of an ingress path to the default port:

move2kube/internal/apiresource/service.go

Line 413 in 0a6db00

ServicePort: intstr.IntOrString{Type: intstr.Int, IntVal: defaultServicePort},

Add support for setting a custom port.
Use case: preserving ports while translating docker compose and old k8s projects.
@ashokponkumar ashokponkumar added this to Backlog in Move2Kube Nov 13, 2020
@ashokponkumar ashokponkumar added this to Backlog in Move2Kube Nov 13, 2020
@ashokponkumar
Copy link
Member

@HarikrishnanBalagopal This issue is fixed in the latest release, isn't it?

@ashokponkumar ashokponkumar moved this from Backlog to Next Sprint in Move2Kube Dec 4, 2020
This was linked to pull requests Dec 6, 2020
Fix ingress ports and paths #115
Merged
Fix ingress path routing and service ports. Update cluster metadata. Change portMergeOptimizer. #195
Merged
Added names for ports. Removed rewriting of paths in Ingress. #205
Merged
Move2Kube automation moved this from Next Sprint to Done Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarikrishnanBalagopal HarikrishnanBalagopal

Labels
backlog
Projects
Move2Kube
Done
Move2Kube
Backlog
Milestone
No milestone
2 participants
@ashokponkumar @HarikrishnanBalagopal