Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF/Dockerfile: Funky character in PORT env var and duplicate containerPort elements in deployment yaml #136

Closed
asinghee opened this issue Oct 29, 2020 · 7 comments · Fixed by #233 or #195
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@asinghee
Copy link

I see two weird things in the deployment yaml generated when running the local UI version on the cloud-foundry sample app in move2kube-demos:

  1. funky character for the value of PORT env var
  2. Duplicate containerPort elements for the same 8080 port in the ports section

I targzipped the cloud-foundry sample folder, and uploaded to the UI. Did not run collect. Chose new Dockerfile plan option.

Attaching screen shot.
Q&A cache in the follow up comment below.

image

@asinghee
Copy link
Author

Q&A cache:

apiVersion: move2kube.konveyor.io/v1alpha1
kind: QACache
spec:
  solutions:
    - description: Which services should we expose?
      context:
        - An Ingress object will be created for every exposed service.
      solution:
        type: MultiSelect
        default:
          - move2kube-demo-cf
        options:
          - move2kube-demo-cf
        answer:
          - move2kube-demo-cf
      resolved: true
    - description: 'Select the registry where your images are hosted:'
      context:
        - You can always change it later by changing the yamls.
      solution:
        type: Select
        default:
          - docker.io
        options:
          - Other
          - docker.io
        answer:
          - docker.io
      resolved: true
    - description: 'Enter the namespace where the new images are pushed : '
      context:
        - 'Ex : cf'
      solution:
        type: Input
        default:
          - cf
        answer:
          - myns
      resolved: true
    - description: '[docker.io] What type of container registry login do you want to use?'
      context:
        - Docker login from config mode, will use the default config from your local machine.
      solution:
        type: Select
        default:
          - No authentication
        options:
          - Use existing pull secret
          - No authentication
          - UserName/Password
        answer:
          - Use existing pull secret
      resolved: true
    - description: '[docker.io] Enter the name of the pull secret : '
      context:
        - The pull secret should exist in the namespace where you will be deploying the application.
      solution:
        type: Input
        default:
          - ""
        answer:
          - blah
      resolved: true

@ashokponkumar ashokponkumar self-assigned this Oct 29, 2020
@ashokponkumar
Copy link
Member

@pabloloyola Can you please take a look at this and identify where the issue is?

@ashokponkumar ashokponkumar added this to Backlog in Move2Kube Nov 13, 2020
@ashokponkumar ashokponkumar moved this from Backlog to To do in Move2Kube Nov 13, 2020
@ashokponkumar ashokponkumar added this to To do in Move2Kube Nov 13, 2020
@ashokponkumar
Copy link
Member

I guess the funky character issue is fixed by #233. Is the dual container port issue still in the master build? @pabloloyola

@ashokponkumar
Copy link
Member

@Akash-Nayak When you update the documentation for the cloud-foundry sample, please check if this issue is fixed. If it is fixed, do close this issue.

@Akash-Nayak
Copy link
Contributor

@Akash-Nayak When you update the documentation for the cloud-foundry sample, please check if this issue is fixed. If it is fixed, do close this issue.

Yes sure, I will check this when I update the documentation for cloud-foundry sample.

@HarikrishnanBalagopal HarikrishnanBalagopal linked a pull request Nov 18, 2020 that will close this issue
@HarikrishnanBalagopal
Copy link
Contributor

The funky character thing has been fixed by #233

@HarikrishnanBalagopal
Copy link
Contributor

The extra port was being added by portMergeOptimizer. It is fixed by #195

@HarikrishnanBalagopal HarikrishnanBalagopal added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
5 participants