Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more default dockerfile containerizers #26

Closed
ashokponkumar opened this issue Oct 2, 2020 · 7 comments
Closed

Add support for more default dockerfile containerizers #26

ashokponkumar opened this issue Oct 2, 2020 · 7 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest

Comments

@ashokponkumar
Copy link
Member

Adding a new docker file based containerization technique for move2kube involves the following:

  1. Check out other existing dockerfile containerizers in https://github.com/konveyor/move2kube/tree/master/internal/assets/dockerfiles
  2. Write a detect script called m2kdfdetect.sh in a new folder similar to https://github.com/konveyor/move2kube/blob/master/internal/assets/dockerfiles/python/m2kdfdetect.sh
  3. The detect script should return any parameters that will be required by the dockerfile as a json
  4. Write a dockerfile (similar to https://github.com/konveyor/move2kube/blob/master/internal/assets/dockerfiles/python/Dockerfile) which uses the paramters passed above.
  5. Do a make generate
  6. Do a make build
  7. Test whether move2kube translate -s srcfolder, where srcfolder is the folder where a folder containing the application that can be containerized using the above code is present. Check whether move2kube detects it.
  8. Check into https://github.com/konveyor/move2kube/blob/master/internal/assets/dockerfiles/
  9. Create a pull request.
@ashokponkumar ashokponkumar added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest labels Oct 2, 2020
@akhil-ghatiki
Copy link
Contributor

@ashokponkumar wrt point 2 what does "new folder" mean ?
Does it mean folder other than python ?
or
adding totally new folders upon existing folders in /assets/dockerfiles ?

@ashokponkumar
Copy link
Member Author

@ashokponkumar wrt point 2 what does "new folder" mean ?
Does it mean folder other than python ?
or
adding totally new folders upon existing folders in /assets/dockerfiles ?

Totally new folders in /assets/dockerfiles depending on the language you are adding support for.

@ashokponkumar
Copy link
Member Author

@seshapad Can you please take the steps in the description, and elaborate on them and create a step by step process of how to create, test and merge a new containerization for Dockerfile and S2I techniques? Once you have it create a folder named "docs" and place the file inside it and create a PR to the repository.

@akhil-ghatiki
Copy link
Contributor

@ashokponkumar I am working on this.

@ashokponkumar
Copy link
Member Author

@ashokponkumar I am working on this.

Sure @akhil-ghatiki . Do reach out to @seshapad in this thread if you have any questions.

@akhil-ghatiki
Copy link
Contributor

@ashokponkumar Just to reconfirm, I need not commit the generated files from make generate for the PR right ?

Below are the generated files.

internal/assets/constants.go
internal/containerizer/scripts/constants.go
internal/metadata/clusters/constants.go
internal/source/data/constants.go
internal/transformer/templates/constants.go

@ashokponkumar
Copy link
Member Author

@ashokponkumar Just to reconfirm, I need not commit the generated files from make generate for the PR right ?

Below are the generated files.

internal/assets/constants.go
internal/containerizer/scripts/constants.go
internal/metadata/clusters/constants.go
internal/source/data/constants.go
internal/transformer/templates/constants.go

You will have to commit them for the builds to pick up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants