-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby support for the default dockerfile containerizers #50
Conversation
Signed-off-by: Akhil Ghatiki <akhil.ghatiki@gmail.com>
Signed-off-by: Akhil Ghatiki <akhil.ghatiki@gmail.com>
Thanks @akhil-ghatiki for the PR. Much appreciate it. Please feel free to make more PRs as might be appropriate. |
@ashokponkumar I don't exactly understand why this build failed. There are no logs for the failure in details. Can you give me any inputs on this ? |
You can check it out in https://travis-ci.com/github/konveyor/move2kube/builds/189306775. It is essentially failing because If you can add the license headers to the files you added, and did a |
Signed-off-by: Akhil Ghatiki <akhil.ghatiki@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 36.49% 36.49%
=======================================
Files 45 45
Lines 2343 2343
=======================================
Hits 855 855
Misses 1432 1432
Partials 56 56 Continue to review full report at Codecov.
|
Thanks @ashokponkumar. Fixed it. Also, I think we can |
Thanks for the suggestion @akhil-ghatiki . I agree, have created a new issue #51 based on your comment. |
This addresses the #26 issue.
This commit adds support for Ruby in the default dockerfile containerizers.
Followed all the required steps mentioned in the issue.
make generate
- The commit has the generated files required.make build
- The build was successful.move2kube translate -s srcfolder
- Tested with a simple ruby application and move2kube was able to detect it successfully. (Adding the screen shot below for reference)