Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Podman support for move2kube #599

Open
ashokponkumar opened this issue Oct 7, 2021 · 5 comments · May be fixed by #1101
Open

Implement Podman support for move2kube #599

ashokponkumar opened this issue Oct 7, 2021 · 5 comments · May be fixed by #1101
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ashokponkumar
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently running container based transformers requires docker. Podman support would be good too.

Describe the solution you'd like
Implement support for podman. This would involve

  1. Completing https://github.com/konveyor/move2kube/blob/main/environment/container/podmanengine.go, which should fully implement the containerengine interface (
    type ContainerEngine interface {
    ), [An example could be found in https://github.com/konveyor/move2kube/blob/main/environment/container/dockerengine.go for docker]
  2. Adding a condition in
    //TODO: Add Support for podman
    stating when to invoke it.

Describe alternatives you've considered
Using only docker for containers

@rmarting
Copy link
Contributor

Maybe it could be an argument to request to the user, or a question in the UI to choose the container engine to use in the scripts and deployment artifacts generated by the tool. Then the user could choose the right container engine for his/her environment.

The idea is similar when you choose the platform (k8s or OpenShift). Then the artifacts generated will be aligned with that decession.

Of course, docker could be the default one if the user does not set podman.

@ashokponkumar
Copy link
Member Author

That's a good point @rmarting .

The scope of this issue is about what Container runtime needs to use to run its container based Transformers ( which are custom Transformers that can be built as containers). This can be automatically chosen, first it can try docker and if it does not work, then it can try podman. We havn't yet implemented the support for podman. It requires implementing an interface.

The point you have brought up is also valid. We should support creation of scripts with podman/docker. Can you possibly convert your comment into a new issue, so that we can track it to completion.

@ashokponkumar
Copy link
Member Author

@seshapad When we implement support for podman, consider using libpod (https://github.com/containers/podman/tree/main/libpod) instead of requiring external podman binary.

@rmarting
Copy link
Contributor

rmarting commented Nov 2, 2021

That's a good point @rmarting .

The scope of this issue is about what Container runtime needs to use to run its container based Transformers ( which are custom Transformers that can be built as containers). This can be automatically chosen, first it can try docker and if it does not work, then it can try podman. We havn't yet implemented the support for podman. It requires implementing an interface.

The point you have brought up is also valid. We should support creation of scripts with podman/docker. Can you possibly convert your comment into a new issue, so that we can track it to completion.

@ashokponkumar New Enhacement request created here

@mohit-marathe
Copy link

Hello! I'm trying to work on this one. If we want to do CopyDirsFromContainer, CopyDirsToContainer, Stat, StopContainer, CopyDirsToImage in podman(podmanengine.go) like we do in docker(dockerengine.go), we would need to have access to container IDs of the container we created.
Now, one way of doing that is to list the containers and filtering them out by image names i.e. podman ps -q --filter "ancestor=image_name". But the problem arises when there are multiple containers from the same image.
Am I missing something here? @kmehant @HarikrishnanBalagopal @ashokponkumar

@HarikrishnanBalagopal HarikrishnanBalagopal added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants