Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for common/cryptoutils #1074

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

SVKREP
Copy link
Contributor

@SVKREP SVKREP commented Aug 11, 2023

Below functions are tested:

  • common.EncryptRsaCertWrapper
  • common.EncryptAesCbcWithPbkdfWrapper

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the test label Aug 11, 2023
@SVKREP
Copy link
Contributor Author

SVKREP commented Aug 11, 2023

vamsikrishna@Friday common % go test -run TestEncryption
PASS
ok      github.com/konveyor/move2kube/common    0.521s

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.33% 🎉

Comparison is base (41b010a) 14.53% compared to head (8096169) 14.86%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   14.53%   14.86%   +0.33%     
==========================================
  Files          86       86              
  Lines        8181     8181              
==========================================
+ Hits         1189     1216      +27     
+ Misses       6686     6649      -37     
- Partials      306      316      +10     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,23 @@
-----BEGIN CERTIFICATE-----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SVKREP Could you please cite the source of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used this command to generate the certificate:

openssl req -newkey rsa:2048 -nodes -keyout key.pem -x509 -out certificate.pem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Vamsi Krishna <vamsikrishnasatyasi971@gmail.com>
Signed-off-by: Vamsi Krishna <vamsikrishnasatyasi971@gmail.com>
Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seshapad seshapad merged commit 516df66 into konveyor:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants