-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace deprecated ioutil readfile function #1075
Conversation
Thanks for making a pull request! 😃 |
@SVKREP Why is an entire function being replaced to handle a deprecation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it's just removing spaces at the beginning of each line unless I am mistaken. |
@SVKREP can you fetch the latest |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
=======================================
Coverage 14.53% 14.53%
=======================================
Files 86 86
Lines 8181 8181
=======================================
Hits 1189 1189
Misses 6686 6686
Partials 306 306 ☔ View full report in Codecov by Sentry. |
@SVKREP There are some merge conflicts that are required to be resolved, so that we can merge the PR. Can you please rebase the branch (https://github.com/konveyor/move2kube/blob/main/contributing.md#pull-request-process) and resolve the merge conflicts. |
Signed-off-by: Vamsi Krishna <vamsikrishnasatyasi971@gmail.com>
Hi Team, Merge conflicts are fixed, please LTM if you need me do any other changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace ioutil.Readfile -> os.Readfile. As it is deprecated from go v1.16.