Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated ioutil readfile function #1075

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

SVKREP
Copy link
Contributor

@SVKREP SVKREP commented Aug 11, 2023

Replace ioutil.Readfile -> os.Readfile. As it is deprecated from go v1.16.

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Aug 11, 2023
@seshapad
Copy link
Member

@SVKREP Why is an entire function being replaced to handle a deprecation?

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal
Copy link
Contributor

HarikrishnanBalagopal commented Aug 15, 2023

@SVKREP Why is an entire function being replaced to handle a deprecation?

I think it's just removing spaces at the beginning of each line unless I am mistaken.
There's only 2 or 3 places where the actual code has been changed ioutil -> os

@HarikrishnanBalagopal
Copy link
Contributor

@SVKREP can you fetch the latest main and rebase your commits on top of that? There are some merge conflicts.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (947c436) 14.53% compared to head (67509a4) 14.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1075   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files          86       86           
  Lines        8181     8181           
=======================================
  Hits         1189     1189           
  Misses       6686     6686           
  Partials      306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akash-Nayak
Copy link
Contributor

@SVKREP There are some merge conflicts that are required to be resolved, so that we can merge the PR. Can you please rebase the branch (https://github.com/konveyor/move2kube/blob/main/contributing.md#pull-request-process) and resolve the merge conflicts.

Signed-off-by: Vamsi Krishna <vamsikrishnasatyasi971@gmail.com>
@SVKREP
Copy link
Contributor Author

SVKREP commented Aug 20, 2023

Hi Team, Merge conflicts are fixed, please LTM if you need me do any other changes!

Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seshapad seshapad merged commit 41b010a into konveyor:main Aug 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants