Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix install script on Apple devices with Apple Silicon #1076

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

Soumil-07
Copy link
Contributor

On Apple devices with Apple Silicon, such as my M1 MacBook, the install script fails as it tries to install linux version of jq.

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Aug 14, 2023
On Apple devices with Apple Silicon, such as my M1 MacBook, the install
script fails as it tries to install linux version of jq.

Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (41b010a) 14.53% compared to head (fdff1b2) 14.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files          86       86           
  Lines        8181     8181           
=======================================
  Hits         1189     1189           
  Misses       6686     6686           
  Partials      306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 43a1ca8 into konveyor:main Aug 22, 2023
3 checks passed
@Soumil-07 Soumil-07 deleted the fix/install-script branch August 22, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants