Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for replicateDeletionCallback #1077

Merged
merged 4 commits into from
Aug 27, 2023

Conversation

Prakhar-Agarwal-byte
Copy link
Contributor

Added test for replicateDeletionCallback in the filesystem package. These tests cover 2 cases

  1. Destination folder gets created
  2. Created destination folder has the same permissions as the source.

Fixes a part of #881

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the test label Aug 18, 2023
@seshapad
Copy link
Member

@Prakhar-Agarwal-byte Seems like some automated test has failed. Can you please check and fix your code to address it.

filesystem/replicator_test.go Show resolved Hide resolved
filesystem/replicator_test.go Outdated Show resolved Hide resolved
Signed-off-by: prakharagarwal1 <prakharagarwal3031@gmail.com>
Signed-off-by: prakharagarwal1 <prakharagarwal3031@gmail.com>
Signed-off-by: prakharagarwal1 <prakharagarwal3031@gmail.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (6320ccd) 14.86% compared to head (48d88fc) 14.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   14.86%   14.92%   +0.06%     
==========================================
  Files          86       86              
  Lines        8181     8181              
==========================================
+ Hits         1216     1221       +5     
+ Misses       6649     6641       -8     
- Partials      316      319       +3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seshapad seshapad merged commit 3711e4d into konveyor:main Aug 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants