-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an option to let the user provide the entire key PEM data as the answer #1078
Conversation
…answer Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
…answer Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
Thanks for making a pull request! 😃 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
=======================================
Coverage 14.80% 14.80%
=======================================
Files 87 87
Lines 8245 8245
=======================================
Hits 1221 1221
Misses 6705 6705
Partials 319 319 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making a PR. A few changes need to be made but looks good.
Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
…o ssh Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Parthiba-Hazra Thanks for making the requested changes! |
… data as the answer (konveyor#1078) Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
This PR added a feature to let the user provide the entire key PEM data as the answer.
fixes: #1041