Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an option to let the user provide the entire key PEM data as the answer #1078

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

Parthiba-Hazra
Copy link
Contributor

This PR added a feature to let the user provide the entire key PEM data as the answer.

fixes: #1041

…answer

Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
…answer

Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (31f36fe) 14.80% compared to head (c9c21a9) 14.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files          87       87           
  Lines        8245     8245           
=======================================
  Hits         1221     1221           
  Misses       6705     6705           
  Partials      319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Parthiba-Hazra Parthiba-Hazra changed the title fix: Add an option to let the user provide the entire key PEM data as the answer feat: Add an option to let the user provide the entire key PEM data as the answer Aug 23, 2023
@github-actions github-actions bot added feat and removed fix labels Aug 23, 2023
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR. A few changes need to be made but looks good.

common/sshkeys/sshkeys.go Outdated Show resolved Hide resolved
common/sshkeys/sshkeys.go Outdated Show resolved Hide resolved
common/sshkeys/sshkeys.go Outdated Show resolved Hide resolved
common/sshkeys/sshkeys.go Outdated Show resolved Hide resolved
common/sshkeys/sshkeys.go Show resolved Hide resolved
Parthiba-Hazra and others added 3 commits August 27, 2023 12:33
Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
…o ssh

Signed-off-by: Parthiba-Hazra <parthibahazra02@gmail.com>
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit d4deb13 into konveyor:main Sep 28, 2023
3 checks passed
@HarikrishnanBalagopal
Copy link
Contributor

@Parthiba-Hazra Thanks for making the requested changes!

HarikrishnanBalagopal added a commit to HarikrishnanBalagopal/move2kube that referenced this pull request Sep 28, 2023
… data as the answer (konveyor#1078)

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add an option to let the user provide the ssh keys
2 participants