Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: categorize QA engine questions #1100

Merged
merged 10 commits into from
Nov 22, 2023

Conversation

Soumil-07
Copy link
Contributor

Categorizes QA questions as defined by a new mappings file. Adds two flags: --qa-enable and --qa-disable for finer grained control

Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Oct 12, 2023
Soumil-07 and others added 4 commits October 12, 2023 19:26
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
question keys

Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (ec8107f) 14.83% compared to head (faad8f1) 14.93%.

Files Patch % Lines
types/qaengine/qamapping.go 0.00% 13 Missing ⚠️
qaengine/cliengine.go 0.00% 9 Missing ⚠️
qaengine/utils.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   14.83%   14.93%   +0.09%     
==========================================
  Files          87       89       +2     
  Lines        8248     8197      -51     
==========================================
  Hits         1224     1224              
+ Misses       6705     6654      -51     
  Partials      319      319              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Soumil-07 Soumil-07 marked this pull request as ready for review October 13, 2023 07:16
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@Akash-Nayak
Copy link
Contributor

Hi @Soumil-07, last week while you were demoing the categorizing QA feature I think we had found a bug- when categories were specified in a new question in custom starlark-based transformer and they were not getting reflected during the QA in transform phase, and it was still showing as external category. Were you able to fix that bug?

Screenshot 2023-11-02 at 3 04 16 PM

@Soumil-07
Copy link
Contributor Author

Soumil-07 commented Nov 2, 2023

Hi @Soumil-07, last week while you were demoing the categorizing QA feature I think we had found a bug- when categories were specified in a new question in custom starlark-based transformer and they were not getting reflected during the QA in transform phase, and it was still showing as external category. Were you able to fix that bug?

Screenshot 2023-11-02 at 3 04 16 PM

Hi! Apparently it wasn't a bug, I was using the wrong attribute during our demo (I used category, it should be categories). Passing the correct, attribute it properly categorizes the question according to the specified categories.

image

The corresponding Starlark code:

                useStatefulSet = m2k.query({"id": "move2kube."+name +".statefulSet",
                                                "type": "Select",
                                                "options": ["Yes", "No"],
                                                "description": "Use StatefulSet instead of Deployment for the "+ name + " service : ",
                                                "categories": ["external-1"]})

Copy link
Contributor

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akash-Nayak
Copy link
Contributor

@Soumil-07 can you rebase this branch as it is out-of-date with the main branch.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased automatically on Github

@HarikrishnanBalagopal
Copy link
Contributor

Related #861

@HarikrishnanBalagopal HarikrishnanBalagopal changed the title fix: categorize QA engine questions feat: categorize QA engine questions Mar 21, 2024
@github-actions github-actions bot added feat and removed fix labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants