Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit the size of the git clone #1111

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

HarikrishnanBalagopal
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal commented Dec 2, 2023

Set a max repo size while cloning.
Added a --max-clone-size flag to both the plan and transform commands.
It is the maximum size in bytes. Default is -1 where negative values mean infinite bytes.

DOES NOT FIX the bug found in the main branch while making this PR #1110
af4d50b1e5522c2a41c34894aa8cf433f5845bb9

fix: set a max repo size while cloning

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Copy link

github-actions bot commented Dec 2, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
…mic.Int64

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (af4d50b) 14.75% compared to head (9deff51) 14.81%.

Files Patch % Lines
common/vcs/git.go 37.50% 27 Missing and 3 partials ⚠️
common/vcs/vcs.go 0.00% 23 Missing ⚠️
common/vcs/limit.go 11.11% 16 Missing ⚠️
lib/transformer.go 0.00% 12 Missing ⚠️
types/plan/planutils.go 0.00% 10 Missing ⚠️
lib/planner.go 0.00% 7 Missing ⚠️
environment/environment.go 0.00% 2 Missing ⚠️
lib/utils.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   14.75%   14.81%   +0.05%     
==========================================
  Files          89       90       +1     
  Lines        8293     8321      +28     
==========================================
+ Hits         1224     1233       +9     
- Misses       6750     6770      +20     
+ Partials      319      318       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seshapad seshapad merged commit e88cece into konveyor:main Dec 2, 2023
4 checks passed
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/limitsize branch December 2, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants