Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for setting an alias for the move2kube command in the shell #1139

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Sanket-0510
Copy link
Contributor

as discussed here #1135 I feel there is a strong need to address, its all okay if we can't change it during installation but shall surely have section to address the same. Because writing 'move2kube' becomes a tedious task for sure.

Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@KrishAryan
Copy link

KrishAryan commented Jan 29, 2024

@Sanket-0510 I think you forgot to sign your commit.

To fix this please read this

Also please read the contribution.md

@Sanket-0510 Sanket-0510 changed the title instuctions to set allias feat: instuctions to set allias Jan 29, 2024
@github-actions github-actions bot added the feat label Jan 29, 2024
@Sanket-0510
Copy link
Contributor Author

@Sanket-0510 I think you forgot to sign your commit.

To fix this please read this

Also please read the contribution.md

Hey @KrishAryan you can review this.

@KrishAryan
Copy link

@Sanket-0510 I think it would look better if you write 'To keep aliases between sessions, you can save them in your user’s shell configuration profile file' and give the example of only bash script otherwise the readme will look unnecessarily long. I am not a maintainer so I cannot approve this for you but wanted to help save their time.

@Sanket-0510
Copy link
Contributor Author

@Sanket-0510 I think it would look better if you write 'To keep aliases between sessions, you can save them in your user’s shell configuration profile file' and give the example of only bash script otherwise the readme will look unnecessarily long. I am not a maintainer so I cannot approve this for you but wanted to help save their time.

will you please highlight in the code, the exact place

Copy link

@KrishAryan KrishAryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

between line 127 and line 129 you can add the comment and remove zsh and fish section.Also use three hashags in line 127 instead of two so that it can look better.

Also in your second commit which is in go.mod file, why did you do the changes in line 22 and removed line 119

@Sanket-0510
Copy link
Contributor Author

Sanket-0510 commented Jan 30, 2024

between line 127 and line 129 you can add the comment and remove zsh and fish section.Also use three hashags in line 127 instead of two so that it can look better.

Also in your second commit which is in go.mod file, why did you do the changes in line 22 and removed line 119

Hey, actually, it's the Go package manager, I guess, which made the changes. I didn't explicitly change it, and the build is successful on my side, I ran these commands, go fmt go mod tidy make ci may be thats go removing the unnecessary dependencies

@KrishAryan
Copy link

@kmehant can you please review and approve it?

Signed-off-by: sanket <telisanket2002@gmail.com>
Signed-off-by: sanket <telisanket2002@gmail.com>
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal changed the title feat: instuctions to set allias docs: instuctions to set allias Mar 21, 2024
@github-actions github-actions bot added docs and removed feat labels Mar 21, 2024
@HarikrishnanBalagopal HarikrishnanBalagopal changed the title docs: instuctions to set allias docs: add instructions to set alias for the move2kube command in the shell Mar 21, 2024
@HarikrishnanBalagopal HarikrishnanBalagopal changed the title docs: add instructions to set alias for the move2kube command in the shell docs: add instructions for setting an alias for the move2kube command in the shell Mar 21, 2024
@HarikrishnanBalagopal HarikrishnanBalagopal enabled auto-merge (squash) March 21, 2024 08:23
@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 03e702f into konveyor:main Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "m2k" as alias for move2kube on installation of move2kube
4 participants