Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checked if path is empty string or not #1179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NeerajNagure
Copy link

Fixes #1116
Checked is any one of path or parent is empty string and it returns false if its empty string

Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@NeerajNagure NeerajNagure changed the title Checked if path is empty string or not Checked if path is empty string or not [bug] Apr 22, 2024
@NeerajNagure NeerajNagure changed the title Checked if path is empty string or not [bug] bug:Checked if path is empty string or not Apr 22, 2024
@NeerajNagure NeerajNagure changed the title bug:Checked if path is empty string or not fix: Checked if path is empty string or not Apr 22, 2024
@github-actions github-actions bot added the fix label Apr 22, 2024
@kmehant
Copy link
Member

kmehant commented Apr 22, 2024

@NeerajNagure Thank you for the PR.

Did you come across any use case with Move2Kube tool that was passing empty strings to this function and triggered an error? If so can you point us to your use case? (input artifacts and exact command you used with Move2Kube tool)?

@kmehant kmehant assigned kmehant and unassigned kmehant Apr 22, 2024
@kmehant kmehant self-requested a review April 22, 2024 05:21
@NeerajNagure
Copy link
Author

@kmehant there was an issue open #1116 which I tried to fix. I have not came across any such use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: IsParent doesn't handle the case where paths are empty properly
2 participants