Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functionality to copy file permissions from host to container #1182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shashank381
Copy link
Contributor

No description provided.

Signed-off-by: shashank381 <satholashashank@gmail.com>
Copy link

github-actions bot commented May 2, 2024

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (3bf7465) to head (914f27c).
Report is 6 commits behind head on main.

Files Patch % Lines
environment/container/dockerengine.go 25.00% 1 Missing and 2 partials ⚠️
environment/environment.go 0.00% 2 Missing ⚠️
environment/peercontainer.go 33.33% 1 Missing and 1 partial ⚠️
environment/container/utils.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   14.79%   14.80%           
=======================================
  Files          90       90           
  Lines        8401     8410    +9     
=======================================
+ Hits         1243     1245    +2     
- Misses       6835     6842    +7     
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CopyDirsIntoImage(image, newImageName string, paths map[string]string) (err error)
CopyDirsIntoContainer(containerID string, paths map[string]string) (err error)
CopyDirsIntoImage(image, newImageName string, paths map[string]string, copyUIDGID bool) (err error)
CopyDirsIntoContainer(containerID string, paths map[string]string, copyUIDGID bool) (err error) // See here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

Suggested change
CopyDirsIntoContainer(containerID string, paths map[string]string, copyUIDGID bool) (err error) // See here
CopyDirsIntoContainer(containerID string, paths map[string]string, copyUIDGID bool) (err error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants