feat: improve git clone mechanism #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
gabriel-farache
force-pushed
the
feat/improve_git_clone
branch
3 times, most recently
from
97aeca1
to
248aa82
Compare
gabriel-farache
changed the title
gabriel-farache
changed the title
Signed-off-by: gabriel-farache <gfarache@redhat.com>
gabriel-farache
force-pushed
the
feat/improve_git_clone
branch
from
248aa82
to
e30a154
Compare
|
On a side note: I find it strange and un-intuitive to force the creation of the source branch if it does not exists when cloning the repo, this should at least be better advertised (hence using warn instead of debug log level) and even, this behaviour should be explicitly enabled by a flag IMO (maybe it is but I could not find it) |
|
@gabriel-farache could you please fix the build..seems like some of the libraries are affecting the license compliance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving how git clone is performed:
Solves: konveyor/move2kube-api#159