Split CI/CD pipeline logic into multiple files. #84

HarikrishnanBalagopal · 2020-10-18T16:41:20Z

No description provided.

codecov · 2020-10-18T16:56:38Z

Codecov Report

Merging #84 into master will decrease coverage by 1.86%.
The diff coverage is 1.04%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   27.52%   25.66%   -1.86%     
==========================================
  Files          52       59       +7     
  Lines        3408     3655     +247     
==========================================
  Hits          938      938              
- Misses       2409     2656     +247     
  Partials       61       61

Impacted Files	Coverage Δ
internal/apiresource/deployment.go	`0.00% <0.00%> (ø)`
internal/apiresource/eventlistener.go	`0.00% <0.00%> (ø)`
internal/apiresource/pipeline.go	`0.00% <0.00%> (ø)`
internal/apiresource/role.go	`0.00% <0.00%> (ø)`
internal/apiresource/rolebinding.go	`0.00% <0.00%> (ø)`
internal/apiresource/service.go	`0.00% <0.00%> (ø)`
internal/apiresource/serviceaccount.go	`0.00% <0.00%> (ø)`
internal/apiresource/storage.go	`0.00% <0.00%> (ø)`
internal/apiresource/triggerbinding.go	`0.00% <0.00%> (ø)`
internal/apiresource/triggertemplate.go	`0.00% <0.00%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1110288...b572694. Read the comment docs.

ashokponkumar · 2020-10-20T17:21:22Z

internal/apiresource/eventlistener.go

+	irresources := ir.TektonResources.EventListeners
+	objs := []runtime.Object{}
+	for _, irresource := range irresources {
+		objs = append(objs, el.createNewResource(irresource))
+	}
+	return objs


shouldn't we create this only if the eventlistener is in the supported kind?

ashokponkumar · 2020-10-20T17:23:24Z

internal/apiresource/pipeline.go

+	irresources := ir.TektonResources.Pipelines
+	objs := []runtime.Object{}
+	for _, irresource := range irresources {
+		objs = append(objs, p.createNewResource(irresource, ir))
+	}
+	return objs


we should check if it is a supported kind.

ashokponkumar · 2020-10-20T17:24:40Z

internal/apiresource/pipeline.go

+		} else if container.ContainerBuildType == plantypes.S2IContainerBuildTypeValue {
+			log.Errorf("TODO: Implement support for S2I")
+		} else if container.ContainerBuildType == plantypes.CNBContainerBuildTypeValue {
+			log.Errorf("TODO: Implement support for CNB")
+		} else {
+			log.Errorf("Unknown containerization method: %v", container.ContainerBuildType)
+		}


Lets make these as warnings rather than error. we have to think of supporting the reusedockerfile usecase too.

Reuse dockerfile is supported already
https://github.com/HarikrishnanBalagopal/move2kube/blob/splittekton/internal/apiresource/pipeline.go#L85

I thought error is better since this is something that needs to be fixed.
Warning is something that may not need to be fixed.

ashokponkumar · 2020-10-20T17:26:22Z

internal/apiresource/role.go

+
+// CreateNewResources creates the runtime objects from the intermediate representation.
+func (r *Role) CreateNewResources(ir irtypes.IR, supportedKinds []string) []runtime.Object {
+	irresources := ir.Roles


check if role is supported

ashokponkumar · 2020-10-20T17:26:49Z

internal/apiresource/rolebinding.go

+
+// CreateNewResources creates the runtime objects from the intermediate representation.
+func (rb *RoleBinding) CreateNewResources(ir irtypes.IR, supportedKinds []string) []runtime.Object {
+	irresources := ir.RoleBindings


Check if it is supported

ashokponkumar · 2020-10-20T17:27:05Z

internal/apiresource/serviceaccount.go

+
+// CreateNewResources creates the runtime objects from the intermediate representation.
+func (sa *ServiceAccount) CreateNewResources(ir irtypes.IR, supportedKinds []string) []runtime.Object {
+	irresources := ir.ServiceAccounts


Check if it is supported

ashokponkumar · 2020-10-20T17:28:04Z

internal/apiresource/triggerbinding.go

+
+// CreateNewResources creates the runtime objects from the intermediate representation.
+func (tb *TriggerBinding) CreateNewResources(ir irtypes.IR, supportedKinds []string) []runtime.Object {
+	irresources := ir.TektonResources.TriggerBindings


Check if it is supported

ashokponkumar · 2020-10-20T17:28:23Z

internal/apiresource/triggertemplate.go

+
+// CreateNewResources creates the runtime objects from the intermediate representation.
+func (tt *TriggerTemplate) CreateNewResources(ir irtypes.IR, supportedKinds []string) []runtime.Object {
+	irresources := ir.TektonResources.TriggerTemplates


Check if the kind is supported

ashokponkumar · 2020-10-21T11:50:20Z

internal/apiresource/deployment.go

@@ -72,6 +72,7 @@ func (d *Deployment) CreateNewResources(ir irtypes.IR, supportedKinds []string)
 			if common.IsStringPresent(supportedKinds, daemonSetKind) {
 				obj = d.createDaemonSet(service)
 			}
+			log.Errorf("Could not find a valid resource type in cluster to create a daemon set.")


Shouldn't this be in else?

ashokponkumar · 2020-10-21T11:50:34Z

internal/apiresource/deployment.go

@@ -80,6 +81,7 @@ func (d *Deployment) CreateNewResources(ir irtypes.IR, supportedKinds []string)
 				pod.Spec.RestartPolicy = corev1.RestartPolicyOnFailure
 				obj = pod
 			}
+			log.Errorf("Could not find a valid resource type in cluster to create a job/pod.")


shouldn't this be in else?

ashokponkumar · 2020-10-23T15:07:08Z

Lets add a collected cluster with tekton, and we are good to go.

ashokponkumar · 2020-10-24T03:55:32Z

@HarikrishnanBalagopal once you are done with the changes, please rebase. Currently it has some merge conflicts with the master after the previous PR merge.

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

… resources Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

…ress name being the same as the backend service name. Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

HarikrishnanBalagopal linked an issue Oct 18, 2020 that may be closed by this pull request

Split the CI/CD pipeline resource set into multiple apiresources #62

Closed

HarikrishnanBalagopal requested a review from ashokponkumar October 19, 2020 06:10

HarikrishnanBalagopal force-pushed the splittekton branch from 2bfb1fb to 4cf02c1 Compare October 20, 2020 16:56

ashokponkumar requested changes Oct 20, 2020

View reviewed changes

HarikrishnanBalagopal force-pushed the splittekton branch 2 times, most recently from 2bcd79c to 3b70441 Compare October 21, 2020 11:00

HarikrishnanBalagopal requested a review from ashokponkumar October 21, 2020 11:41

ashokponkumar requested changes Oct 21, 2020

View reviewed changes

HarikrishnanBalagopal requested a review from ashokponkumar October 21, 2020 15:32

HarikrishnanBalagopal force-pushed the splittekton branch from f270898 to fde3220 Compare October 23, 2020 14:45

ashokponkumar approved these changes Oct 23, 2020

View reviewed changes

HarikrishnanBalagopal added 4 commits October 24, 2020 09:38

Split tekton into multiple files

4e1785a

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

fixed bug where warning would be printed always

9352752

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

Added tekton cluster info. Ignore old containers while creating CI/CD…

4ba6914

… resources Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

regenerate the contants.go to include the tekton triggers cluster

e0baa36

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

HarikrishnanBalagopal force-pushed the splittekton branch from 94232d9 to f20dc9c Compare October 24, 2020 04:15

fixed bug where we were taking pointer to pointer. Fixed bug with ing…

8780a1e

…ress name being the same as the backend service name. Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

HarikrishnanBalagopal force-pushed the splittekton branch from f20dc9c to 8780a1e Compare October 24, 2020 08:25

HarikrishnanBalagopal added 4 commits October 24, 2020 14:38

Changed variable name to IngressTLSSecretName. removed unused constants

11e2341

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

Removed unused field ExposeService

39be97c

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

fix bugs with names and paths

8eea2aa

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

fix gitDomain

fb7c4f2

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

HarikrishnanBalagopal force-pushed the splittekton branch from 40155b1 to 360481f Compare October 24, 2020 19:00

removed check for supported kinds from tekton resources

b572694

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>

HarikrishnanBalagopal force-pushed the splittekton branch 2 times, most recently from a2b31bc to b572694 Compare October 25, 2020 04:08

HarikrishnanBalagopal requested a review from ashokponkumar October 25, 2020 04:17

ashokponkumar approved these changes Oct 25, 2020

View reviewed changes

ashokponkumar merged commit ebdd1ee into konveyor:master Oct 25, 2020

HarikrishnanBalagopal deleted the splittekton branch October 25, 2020 04:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split CI/CD pipeline logic into multiple files. #84

Split CI/CD pipeline logic into multiple files. #84

HarikrishnanBalagopal commented Oct 18, 2020

codecov bot commented Oct 18, 2020 •

edited

Loading

ashokponkumar Oct 20, 2020

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 21, 2020

HarikrishnanBalagopal Oct 21, 2020 •

edited

Loading

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 20, 2020 •

edited

Loading

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar Oct 20, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar Oct 21, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar Oct 21, 2020

HarikrishnanBalagopal Oct 21, 2020

ashokponkumar commented Oct 23, 2020

ashokponkumar commented Oct 24, 2020

Split CI/CD pipeline logic into multiple files. #84

Split CI/CD pipeline logic into multiple files. #84

Conversation

HarikrishnanBalagopal commented Oct 18, 2020

codecov bot commented Oct 18, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarikrishnanBalagopal Oct 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarikrishnanBalagopal Oct 20, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashokponkumar commented Oct 23, 2020

ashokponkumar commented Oct 24, 2020

codecov bot commented Oct 18, 2020 •

edited

Loading

HarikrishnanBalagopal Oct 21, 2020 •

edited

Loading

HarikrishnanBalagopal Oct 20, 2020 •

edited

Loading