🐛 Treat tags that are inherited from archetype assessments as assessment tags rather than archetype tags #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, tags that applications inherited due to their archetypes' assessments were categorized as archetype tags rather than assessment tags. This corrects the categorization, and in addition fixes some bugs where tags could be inherited from archived assessments. Fixes https://issues.redhat.com/browse/MTA-1972 Signed-off-by: Sam Lucidi <slucidi@redhat.com>
|
Tested and looks good! 
|
aufi
approved these changes
Feb 16, 2024
ibolton336
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Feb 16, 2024
<img width="512" alt="Screenshot 2024-02-14 at 1 47 42 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/767b6c34-f097-4f08-9260-56bc28ff9c07"> Capitalized source names - previously assessment and archetype sources were lowercase which led to a confusing UX. Motivated by konveyor/tackle2-hub#603 incoming changes. Signed-off-by: Ian Bolton <ibolton@redhat.com>
mansam
added
the
cherry-pick/release-0.3
mansam
added a commit
to mansam/tackle2-hub
that referenced
this pull request
Feb 28, 2024
…ent tags rather than archetype tags (konveyor#603) Prior to this commit, tags that applications inherited due to their archetypes' assessments were categorized as archetype tags rather than assessment tags. This corrects the categorization, and in addition fixes some bugs where tags could be inherited from archived assessments. Fixes https://issues.redhat.com/browse/MTA-1972 Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
added a commit
that referenced
this pull request
Feb 28, 2024
…ssessments as assessment tags rather than archetype tags (#603) (#611) Prior to this commit, tags that applications inherited due to their archetypes' assessments were categorized as archetype tags rather than assessment tags. This corrects the categorization, and in addition fixes some bugs where tags could be inherited from archived assessments. Fixes https://issues.redhat.com/browse/MTA-1972 Signed-off-by: Sam Lucidi <slucidi@redhat.com>
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, tags that applications inherited due to their archetypes' assessments were categorized as archetype tags rather than assessment tags. This corrects the categorization, and in addition fixes some bugs where tags could be inherited from archived assessments.
Fixes https://issues.redhat.com/browse/MTA-1972