Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update padding to display Report adoption correctly #187

Merged
merged 1 commit into from
May 11, 2022

Conversation

aufi
Copy link
Member

@aufi aufi commented May 11, 2022

There was reported overlapping of application circle and adoption candidate chart description. Updating paddings to make title text readable.

Note, this is my first commit to the Tackle2 UI, I'm happy for every possible feedback. (the change might be naive, but looks to me to solving the reported issue). Sample screenshots attached in comments.

https://issues.redhat.com/browse/TACKLE-529

There was reported overlapping of application circle and adoption
candidate chart description. Updating paddings to make title text readable.

https://issues.redhat.com/browse/TACKLE-529
@aufi
Copy link
Member Author

aufi commented May 11, 2022

Before:
image

After (with change from this PR):
image

@aufi aufi requested a review from gildub May 11, 2022 12:55
Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gildub gildub merged commit 68994f5 into konveyor:main May 11, 2022
@aufi aufi mentioned this pull request May 11, 2022
aufi added a commit to aufi/tackle2-ui that referenced this pull request May 11, 2022
Followup for konveyor#187 fixing
space under title after got feedback from QE.
gildub pushed a commit that referenced this pull request May 11, 2022
Followup for #187 fixing
space under title after got feedback from QE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants