Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TACKLE-616: Close modal on import with validation errors & show notification with error #241

Merged
merged 4 commits into from May 19, 2022

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented May 17, 2022

@ibolton336 ibolton336 marked this pull request as ready for review May 18, 2022 16:25
@ibolton336 ibolton336 changed the title [WIP] Bug 616 TACKLE-616: Disable import button after an error occurs May 18, 2022
@ibolton336 ibolton336 changed the title TACKLE-616: Disable import button after an error occurs TACKLE-616: Close modal on import with validation errors & show notification with error May 18, 2022
@aufi
Copy link
Member

aufi commented May 19, 2022

I can confirm the modal get closed and correct error message is displayed in top right corner, looks good to me!

image

@ibolton336 ibolton336 merged commit d4cba79 into konveyor:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants