-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add "addons" tab for running arbitrary tackle addons #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things - looking good overall!
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
@@ -400,7 +405,7 @@ export interface Taskgroup { | |||
id?: number; | |||
name: string; | |||
addon: string; | |||
data: TaskData; | |||
data: any; // TODO(djzager) - may want to fix this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use the TaskData type here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem here is that the data
we are trying to submit almost certainly will not match the TaskData type. TaskData as it currently exists is only true for running a Windup task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This point still remains but the other issues have been addressed.
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
de364c8
to
1b4d0f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - There is one outstanding bug with the code-editor component that prevents right clicking inside the window to paste contents. Seems to be an issue with the component itself rather than with the implementation here.
This PR introduces a new tab called "Addons" that allows users to run arbitrary addons (assuming extra addons are installed). The "Addons" tab is only visible if extra addons are visible to the hub. Signed-off-by: David Zager <david.j.zager@gmail.com>
This PR introduces a new tab called "Addons" that allows users to run arbitrary addons (assuming extra addons are installed). The "Addons" tab is only visible if extra addons are visible to the hub. Signed-off-by: David Zager <david.j.zager@gmail.com>
This PR introduces a new tab called "Addons" that allows users to run arbitrary addons (assuming extra addons are installed). The "Addons" tab is only visible if extra addons are visible to the hub.