✨ add "addons" tab for running arbitrary tackle addons #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
requested changes
Jan 9, 2023
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
| @@ -400,7 +405,7 @@ export interface Taskgroup { | |||
| id?: number; | |||
| name: string; | |||
| addon: string; | |||
| data: TaskData; | |||
| data: any; // TODO(djzager) - may want to fix this | |||
There was a problem hiding this comment.
Any reason not to use the TaskData type here?
There was a problem hiding this comment.
the problem here is that the data we are trying to submit almost certainly will not match the TaskData type. TaskData as it currently exists is only true for running a Windup task.
There was a problem hiding this comment.
This point still remains but the other issues have been addressed.
...ications/components/application-list-expanded-area/application-list-expanded-area-extras.tsx
Outdated
Show resolved
Hide resolved
djzager
force-pushed
the
tkltest
branch
2 times, most recently
from
de364c8
to
1b4d0f9
Compare
ibolton336
approved these changes
Feb 8, 2023
djzager
changed the title
This PR introduces a new tab called "Addons" that allows users to run arbitrary addons (assuming extra addons are installed). The "Addons" tab is only visible if extra addons are visible to the hub. Signed-off-by: David Zager <david.j.zager@gmail.com>
djzager
added a commit
to djzager/tackle2-ui
that referenced
this pull request
Apr 10, 2023
This PR introduces a new tab called "Addons" that allows users to run arbitrary addons (assuming extra addons are installed). The "Addons" tab is only visible if extra addons are visible to the hub. Signed-off-by: David Zager <david.j.zager@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new tab called "Addons" that allows users to run arbitrary addons (assuming extra addons are installed). The "Addons" tab is only visible if extra addons are visible to the hub.