Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags/TagTypes: Workaround Foreign key constraint error #94

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Tags/TagTypes: Workaround Foreign key constraint error #94

merged 1 commit into from
Apr 13, 2022

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Apr 13, 2022

  • Disables the delete button for tag types when tags are attached to it.
  • Display a user friendly error notification "Cannot delete a used tag" when trying to delete a tag that is used .

For the latter, a long term solution to disable delete tag button would require to fetch applications to determine if the tag to be deleted is used or not. This would require a bigger effort because Tackle 1 UI didn't have foreign key constraint enabled for tags and tag types and therefore wasn't designed to handle it.

https://issues.redhat.com/projects/TACKLE/issues/TACKLE-446

@gildub gildub merged commit 314603e into konveyor:main Apr 13, 2022
@gildub gildub deleted the tags-handle-constraint branch April 13, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants