Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Plan Wizard: Select VMs step: add case for "unknown" analytics status (use revisionAnalyzed property) #238

Closed
mturley opened this issue Nov 18, 2020 · 2 comments · Fixed by #242
Assignees

Comments

@mturley
Copy link
Collaborator

mturley commented Nov 18, 2020

Related to #126, could be the same PR (finalizing all the stuff about that migration analytics column).

Slack message from Jeff:

I posted on Sat that my PSI cluster has initial MA integration w/ provider inventory and the concerns are now based on MA. You'll notice a few other things. 1. All resources now have a revision field that is incremented on update. 2. The VM has a revisionAnalyzed field that indicates which revision the concerns are based on. If the revisionAnalyzed < revision, the UI should interpret as unknwon and recommend something like a ❓ icon. (edited)
Changes are analyzed asynchronously so could be a short window where the VM update is reflected in the inventory and the analytics has not been updated.

We need to make sure to handle that revisionAnalyzed < revision case and display an "unknown" message. We could perhaps add an "unknown" variant to the StatusIcon in lib-ui.

@mturley
Copy link
Collaborator Author

mturley commented Nov 20, 2020

Related: #126

@mturley
Copy link
Collaborator Author

mturley commented Nov 20, 2020

Note: we should make sure we have polling enabled for this data so the unknown case will go away if it is updated in the API. I think we may have turned off polling for the wizard.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants