Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Inventory payload request to use namespace #209

Merged
merged 3 commits into from Nov 16, 2020
Merged

Inventory payload request to use namespace #209

merged 3 commits into from Nov 16, 2020

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Nov 12, 2020

The API call to the inventory-payload app has changed slightly from:
/api/v1/extract?providers=provider1,provider2
to:
/api/v1/extract?providers=namespace1/provider1,namespace2/provider2

@gildub gildub changed the title Inventory payload requests to use namespace Inventory payload request to use namespace Nov 12, 2020
@konveyor-preview-bot
Copy link

🚀 Deployed Preview: http://konveyor-virt-ui-pr-209-preview.surge.sh

@gildub gildub marked this pull request as ready for review November 13, 2020 08:47
@gildub gildub requested a review from a team November 13, 2020 08:47
@gildub
Copy link
Contributor Author

gildub commented Nov 13, 2020

@mturley, @konveyor/virt-payload has been updated, could you please review?

@gildub gildub mentioned this pull request Nov 13, 2020
@gildub
Copy link
Contributor Author

gildub commented Nov 16, 2020

Updated after http proxy addition.

Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @gildub , I started a review and wrote this comment on Friday and then forgot to submit it. Once this change is made I'll approve and merge!

@mturley mturley merged commit 61a2c74 into kubev2v:master Nov 16, 2020
@gildub gildub deleted the inventory-payload-by-namespace branch November 16, 2020 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants