Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTF output option to tnefparse #39

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Conversation

jrideout
Copy link
Collaborator

@jrideout jrideout commented Nov 30, 2018

Changes:

  • add an -rb command line option for rtf output
  • Command line output when printing byte object bodies is now correct
  • Correctly out the exit code on success and failure
  • Optionally decompress the rtf file if compressed_rtf is present. This makes it a recommended, but not required dependency.

@jrideout
Copy link
Collaborator Author

The byte size difference between py2 and py3 is interesting. I'll figure it out.

@jrideout jrideout mentioned this pull request Nov 30, 2018
3 tasks
@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #39 into master will increase coverage by 0.59%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   90.21%   90.81%   +0.59%     
==========================================
  Files           5        5              
  Lines         961      980      +19     
  Branches       93       97       +4     
==========================================
+ Hits          867      890      +23     
+ Misses         69       68       -1     
+ Partials       25       22       -3
Impacted Files Coverage Δ
tnefparse/cmdline.py 85.07% <100%> (+13.14%) ⬆️
tnefparse/tnef.py 88.88% <75%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8d25f...88f5ab8. Read the comment docs.

@petri
Copy link
Member

petri commented Nov 30, 2018

Looks good to me. Thanks for the extra tests! Is it too much to ask to bring the patch test coverage up a notch more to satisfy our Codecov overlord? If there are no straightforward low-hanging approaches to do that, we can relax the Codecov patch requirement, at least in this case.

@jrideout
Copy link
Collaborator Author

The only thing that doesn't have coverage on the patch is testing the case of an ImportError when compressed_rtf is not installed. I think we should relax the Codecov patch requirement in this case.

@jrideout jrideout merged commit a3983ab into koodaamo:master Nov 30, 2018
@jrideout jrideout deleted the rtf_cmd branch November 30, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants