-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PR including files + fwd templates. #1
Conversation
fwd-template.json
Outdated
"output": ".", | ||
"builds": [ | ||
{ | ||
"name": "default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "default", | |
"name": "7.4-fpm-alpine", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good if we add 7.1, 7.2, 7.3
&& tar -C /usr/local/bin -xzvf dockerize-alpine-linux-amd64-$DOCKERIZE_VERSION.tar.gz \ | ||
&& rm dockerize-alpine-linux-amd64-$DOCKERIZE_VERSION.tar.gz | ||
|
||
COPY kool.ini /kool/kool.tmpl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add cp "/usr/local/etc/php/php.ini-production" "/usr/local/etc/php/php.ini"
template/Dockerfile.blade.php
Outdated
ENV PHP_MEMORY_LIMIT=256M \ | ||
PHP_UPLOAD_MAX_FILESIZE=50M \ | ||
PHP_POST_MAX_SIZE=50M \ | ||
PHP_MAX_EXECUTION_TIME=300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max execution 30
template/Dockerfile.blade.php
Outdated
|
||
ENTRYPOINT [ "dockerize", "-template", "/kool/kool.tmpl:/usr/local/etc/php/conf.d/kool.ini", "docker-entrypoint.sh" ] | ||
|
||
CMD ["php-fpm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove if it's the same form base
.github/docker.yml
Outdated
|
||
- name: Test docker images | ||
run: | | ||
docker run kooldev/wordpress:${{ matrix.version }} php /usr/src/wordpress/index.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move up
@dbpolito I just submitted the CR corrections/suggestions as per your comments. Cheers! |
Beautiful ❤️ |
No description provided.