Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using docker-compose from a container when no docker-compose available #243

Merged
merged 11 commits into from Jan 26, 2021

Conversation

fabriciojs
Copy link
Member

@fabriciojs fabriciojs commented Jan 23, 2021

related to #241 #166

  • Refactor start, stop and exec commands
  • Refactor logs, status commands
  • Add tests to new compose.DockerCompose command
  • Fix always using --user on docker-compose exec
  • Make usage of local docker-compose when available as default
  • Update tests accordingly

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #243 (c6837b4) into master (bb23a49) will increase coverage by 0.13%.
The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   87.64%   87.77%   +0.13%     
==========================================
  Files          65       66       +1     
  Lines        2468     2512      +44     
==========================================
+ Hits         2163     2205      +42     
- Misses        282      283       +1     
- Partials       23       24       +1     
Impacted Files Coverage Δ
cmd/shell/shell.go 80.00% <77.77%> (-2.11%) ⬇️
cmd/checker/checker.go 100.00% <100.00%> (ø)
cmd/compose/docker-compose.go 100.00% <100.00%> (ø)
cmd/docker.go 100.00% <100.00%> (ø)
cmd/exec.go 100.00% <100.00%> (ø)
cmd/logs.go 100.00% <100.00%> (ø)
cmd/start.go 100.00% <100.00%> (ø)
cmd/status.go 100.00% <100.00%> (ø)
cmd/stop.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb23a49...c6837b4. Read the comment docs.

@fabriciojs fabriciojs marked this pull request as ready for review January 23, 2021 14:32
@fabriciojs fabriciojs marked this pull request as draft January 23, 2021 19:33
@fabriciojs fabriciojs marked this pull request as ready for review January 24, 2021 05:15
cmd/exec.go Show resolved Hide resolved
@fabriciojs fabriciojs changed the title using docker-compose always from a container using docker-compose from a container when no docker-compose available Jan 25, 2021
README.md Outdated Show resolved Hide resolved
docs/4-Commands/0-kool.md Show resolved Hide resolved
cmd/exec.go Show resolved Hide resolved
Co-authored-by: Daniel Jun Suguimoto <danielsuguimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants