Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo + update kool create #244

Merged
merged 8 commits into from Jan 28, 2021
Merged

Hugo + update kool create #244

merged 8 commits into from Jan 28, 2021

Conversation

fabriciojs
Copy link
Member

@fabriciojs fabriciojs commented Jan 27, 2021

Adding new preset for Hugo the static site builder - https://gohugo.io/

  • 🏆 Feature - new preset

TL;DR

Adding new preset for Hugo to locally develop websites. Refactored how preset-config.yml create key handles the target folder.

  • Add Hugo preset
  • Changed kool create <preset> <folder> to put the <folder> into an environment variable and then updated the create: recipes on each existing preset to use it explicitly.

🎯 Kool Target version:

  • next minor release

Expected behavior

With the new implementation kool create hugo my-website should create a new Hugo site and install the presets; kool preset hugo should add both kool.yml and docker-compose.yml to the local directory.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #244 (d19cc09) into master (715028e) will increase coverage by 0.25%.
The diff coverage is 98.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   87.77%   88.03%   +0.25%     
==========================================
  Files          66       66              
  Lines        2512     2565      +53     
==========================================
+ Hits         2205     2258      +53     
  Misses        283      283              
  Partials       24       24              
Impacted Files Coverage Δ
cmd/create.go 90.47% <88.88%> (+0.47%) ⬆️
cmd/presets/configs.go 100.00% <100.00%> (ø)
cmd/presets/presets.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715028e...0e52a55. Read the comment docs.

@fabriciojs fabriciojs changed the title Hugo Hugo + update kool create Jan 27, 2021
@@ -0,0 +1,3 @@
scripts:
hugo: kool docker -p 1313:1313 klakegg/hugo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use hugo entrypoint that we already have inside the container with kool exec?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I didn't give much thought into this. The good thing about using kool docker instead of kool exec is not depending on the running container. So the option would be kool exec app hugo. I am fine either way, let me know what you think is best!

@fabriciojs fabriciojs merged commit 150bc69 into master Jan 28, 2021
@fabriciojs fabriciojs deleted the hugo branch January 28, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants