Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deploy file from laravel preset #247

Merged
merged 1 commit into from Feb 1, 2021
Merged

Conversation

fabriciojs
Copy link
Member

Removing files from preset only meant for kool deploy which by itself doesn't make sense to have in the current default preset.

Later when we better structure and document the deploy feature we shall revisit such files.

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #247 (553d500) into master (4d7176e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   88.03%   87.98%   -0.05%     
==========================================
  Files          66       66              
  Lines        2565     2556       -9     
==========================================
- Hits         2258     2249       -9     
  Misses        283      283              
  Partials       24       24              
Impacted Files Coverage Δ
cmd/presets/presets.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7176e...553d500. Read the comment docs.

@dbpolito
Copy link
Member

dbpolito commented Feb 1, 2021

well while i agree the main idea was for using on kool cloud, i think it's still good for people that wants to deploy so their cloud env... i'm ok with removing as we don't have it documented... but we might want to re-introduce it even without kool cloud with some good docs...

@fabriciojs
Copy link
Member Author

@dbpolito I hear you! Indeed we can provide it as a helper for self-deploying. The idea in the back of my mind right now is introducing a secondary preset laravel:deploy so we have the necessary files. Let's put that in the roadmap soonish.

@fabriciojs fabriciojs merged commit 0ba1621 into master Feb 1, 2021
@fabriciojs fabriciojs deleted the fix-laravel-preset branch February 1, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants