Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks to README, security notes, contributing guide, PR template #249

Merged
merged 3 commits into from Feb 1, 2021

Conversation

fabriciojs
Copy link
Member

Issue #248
馃 Bug Fix No
馃弳 Feature No
馃摑 Refactor No
馃摉 Documentation Yes
鈿狅笍 Break Change No

Description

  • Simplifying and reducing a lot the PR template
  • Creating CONTRIBUTING.md
  • Removing old demo video, linking to ASCII Cinema page
  • Fix outdated security notes on supporting versions

Notes

How it will look like for the developer opening the PR:

image

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #249 (bca0438) into master (4d7176e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          66       66           
  Lines        2565     2565           
=======================================
  Hits         2258     2258           
  Misses        283      283           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4d7176e...cb7e8f9. Read the comment docs.

@fabriciojs fabriciojs merged commit c8eaaf8 into master Feb 1, 2021
@fabriciojs fabriciojs deleted the org-stuff branch February 1, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants