Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error message for typos on kool run #252

Merged
merged 1 commit into from Feb 1, 2021

Conversation

fabriciojs
Copy link
Member

Issue #251
⚠️ Break Change No

Description

  • Adding new error type for handling possible typos on kool run usage.
  • NOT INCLUDED on this the offering to the user to quickly run the correct command. Future implementation should expand parser.ErrPossibleTypo to handle it.

Notes

New error messages when the targetted script is not found, but we have a similar script name:

image

@fabriciojs fabriciojs changed the title add parser.ErrPossibleTypo error handling - possible typos on kool run Improving error message for typos on kool run Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #252 (76a3033) into master (4d7176e) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   88.03%   88.16%   +0.13%     
==========================================
  Files          66       66              
  Lines        2565     2578      +13     
==========================================
+ Hits         2258     2273      +15     
+ Misses        283      280       -3     
- Partials       24       25       +1     
Impacted Files Coverage Δ
cmd/parser/parser.go 83.60% <100.00%> (+2.83%) ⬆️
cmd/parser/yml.go 82.75% <100.00%> (+1.62%) ⬆️
cmd/run.go 100.00% <100.00%> (ø)
cmd/shell/shell.go 82.10% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7176e...e10ea7e. Read the comment docs.

@danielsuguimoto danielsuguimoto merged commit 779670b into master Feb 1, 2021
@fabriciojs fabriciojs deleted the kool_run-typo branch February 1, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants