Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken (*compose.DockerCompose).Copy method #271

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

fabriciojs
Copy link
Member

Issue -
馃 Bug Fix Yes
鈿狅笍 Break Change Yes/No

Description

Recently introduced builder.Command.Copy() was making compose.DockerCompose to be lost within shell.Interactive, which would cause for not found command errors.


Notes

The test here tackles only the Copy itself. I plan on writing some end-to-end test so we can catch stuff like this before in our workflow.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #271 (bfea26e) into master (510952b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          67       67           
  Lines        2629     2630    +1     
=======================================
+ Hits         2326     2327    +1     
  Misses        281      281           
  Partials       22       22           
Impacted Files Coverage 螖
cmd/compose/docker-compose.go 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 510952b...6ea44f4. Read the comment docs.

@danielsuguimoto danielsuguimoto merged commit 8a8aec4 into master Feb 9, 2021
@danielsuguimoto danielsuguimoto deleted the fix-docker_compose branch February 9, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants