Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on kool deploy missing files #273

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

fabriciojs
Copy link
Member

Issue #194
馃 Bug Fix Yes
鈿狅笍 Break Change No

Description

In case the file we are trying to list does not exist we only display a warning, since that will only happen in a git repository context and therefore should be the case of uncommitted deleted files like in the reported issue.


Notes

The new message will be:

image

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #273 (1c6ed4d) into master (8a8aec4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          67       67           
  Lines        2630     2630           
=======================================
  Hits         2329     2329           
  Misses        278      278           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8a8aec4...55936b2. Read the comment docs.

@danielsuguimoto danielsuguimoto merged commit 4320a91 into master Feb 16, 2021
@danielsuguimoto danielsuguimoto deleted the deploy-tar branch February 16, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants