kool deploy destroy + overall API consuming improvements and tests #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 88.47% 92.90% +4.43%
==========================================
Files 68 70 +2
Lines 2689 2736 +47
==========================================
+ Hits 2379 2542 +163
+ Misses 286 158 -128
- Partials 24 36 +12
Continue to review full report at Codecov.
|
|
With this, we are caught up with most of the |
danielsuguimoto
suggested changes
Feb 23, 2021
| } | ||
|
|
||
| if err != nil { | ||
| if errAPI, is := err.(*ErrAPI); is { |
There was a problem hiding this comment.
can't we use errors.Is(err, ErrApi)?
There was a problem hiding this comment.
As I understand, errors.Is() checks for value, and not type... since each new pointer of *ErrAPI would have its own possible value, asserting the underlying type behind the interface seems like the way to go.
danielsuguimoto
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing new
kool deploy destroycommand that destroys the current set environment deployed on Kool Cloud.Notes