Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preset: add expressjs preset #376

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

danielsuguimoto
Copy link
Contributor

Issue #
🪲 Bug Fix No
🏆 Feature Yes
📝 Refactor No
📖 Documentation Yes
⚠️ Break Change No

Description
It adds a new preset: node express


@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #376 (5f08744) into master (a8fc06a) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 5f08744 differs from pull request most recent head 718a54b. Consider uploading reports for the commit 718a54b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   94.59%   94.76%   +0.17%     
==========================================
  Files          70       70              
  Lines        3481     3556      +75     
==========================================
+ Hits         3293     3370      +77     
+ Misses        152      149       -3     
- Partials       36       37       +1     
Impacted Files Coverage Δ
core/presets/configs.go 100.00% <100.00%> (ø)
core/presets/presets.go 100.00% <100.00%> (ø)
core/presets/templates.go 100.00% <100.00%> (ø)
core/shell/shell.go 82.70% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fc06a...718a54b. Read the comment docs.

@fabriciojs fabriciojs merged commit a1d5d60 into kool-dev:master Sep 30, 2021
@@ -0,0 +1,174 @@
# Start a Node.js Project with Docker in 2 Easy Steps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriciojs - shouldn't this heading be "Start an Express.js Project...", instead of "Node.js"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriciojs - shouldn't this heading be "Start an Express.js Project...", instead of "Node.js"?

yes...sorry, my mistake...thanks

@danielsuguimoto danielsuguimoto deleted the expressjs branch July 21, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants