New Presets Structure

[fabriciojs]

Issue	#312
🏆 Feature	Yes
📝 Refactor	Yes
📖 Documentation	Yes
⚠️ Break Change	No

Description

A new way of describing a preset, and some new features along the way.

TDB

---

Notes

Left over to do:

• Finish refactoring other presets.
• Recover test coverage on code.
• Add test coverage to presets consistency.

[codecov]

Codecov Report

Merging #386 (c984f41) into master (63eb964) will decrease coverage by 11.38%.
The diff coverage is 39.25%.

@@             Coverage Diff             @@
##           master     #386       +/-   ##
===========================================
- Coverage   93.96%   82.57%   -11.39%     
===========================================
  Files          70       72        +2     
  Lines        3527     2629      -898     
===========================================
- Hits         3314     2171     -1143     
- Misses        168      406      +238     
- Partials       45       52        +7     

Impacted Files	Coverage Δ
commands/preset.go	47.82% <0.00%> (-52.18%)	⬇️
core/automate/executor.go	0.00% <0.00%> (ø)
core/automate/recipes.go	0.00% <0.00%> (ø)
core/builder/command.go	100.00% <ø> (ø)
core/parser/fake_yml.go	100.00% <ø> (ø)
core/parser/yml.go	85.29% <ø> (ø)
core/shell/fake_shell.go	90.47% <0.00%> (-4.53%)	⬇️
services/yamler/output.go	48.00% <48.00%> (ø)
core/shell/shell.go	78.51% <50.00%> (-2.97%)	⬇️
core/presets/parser.go	49.49% <50.56%> (-50.51%)	⬇️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63eb964...c984f41. Read the comment docs.

[indiegenus]

@fabriciojs - couple of quick comments about your English in the Preset output:

→ merging laravel-scripts.yml onto kool.yml

• for all "merging" lines, change onto to into

⇒ Tailor up your setup

• "Tailor up" is not really used. I'd go with "Customize your setup".

[dbpolito]

Great progress!! Looking really good.

One thing is i think it got too verbose... maybe these merging and docker pull messages are too much and can be hidden with a verbose flag that will make them appear.

[fabriciojs]

Great progress!! Looking really good.

One thing is i think it got too verbose... maybe these merging and docker pull messages are too much and can be hidden with a verbose flag that will make them appear.

So I think this is a reasonable and good point. Initially, I imagine being more verbose would be a nice thing, so the user knows what is going on. I suggest we go like is for now... but I would like to hear others' opinions as well.

[fabriciojs]

@dbpolito @danielsuguimoto @indiegenus - this PR is final for all intentions and purposes.

The drawback here is the decrease in test coverage, which I hope to recover in future PRs - that is acceptable and will allow for more people to contribute on doing that.

I plan to merge this during this weekend or early next week, then I will create a short roadmap to a new tagged version.

After this next tag, the plan is to focus on 2.0 totally - allowing for breaking changes.