Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Recipe + kool recipes improvement #395

Merged
merged 6 commits into from
Nov 30, 2021
Merged

PDF Recipe + kool recipes improvement #395

merged 6 commits into from
Nov 30, 2021

Conversation

fabriciojs
Copy link
Member

Issue #
🏆 Feature Yes
⚠️ Break Change No

Description

  • PDF recipe
  • Listing available recipes

@fabriciojs fabriciojs changed the title Recipes PDF Recipe + kool recipes improvement Nov 28, 2021
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #395 (e500dfb) into master (33d1549) will decrease coverage by 0.75%.
The diff coverage is 29.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   82.33%   81.57%   -0.76%     
==========================================
  Files          72       72              
  Lines        2643     2670      +27     
==========================================
+ Hits         2176     2178       +2     
- Misses        414      437      +23     
- Partials       53       55       +2     
Impacted Files Coverage Δ
core/automate/executor.go 0.00% <0.00%> (ø)
core/automate/recipes.go 0.00% <0.00%> (ø)
commands/recipe.go 51.61% <26.66%> (-30.21%) ⬇️
commands/run.go 100.00% <100.00%> (ø)
commands/start.go 93.50% <100.00%> (+0.08%) ⬆️
commands/stop.go 100.00% <100.00%> (ø)
core/shell/shell.go 80.00% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d1549...e500dfb. Read the comment docs.

commands/recipe.go Outdated Show resolved Hide resolved
@danielsuguimoto
Copy link
Contributor

@fabriciojs linter check has failed. After fixing it, this PR is ready to go!

@fabriciojs fabriciojs merged commit b8828cc into master Nov 30, 2021
@fabriciojs fabriciojs deleted the recipes branch November 30, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants