Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kool CLI 2.0 - kool cloud and more #451

Merged
merged 30 commits into from
Mar 17, 2023
Merged

Kool CLI 2.0 - kool cloud and more #451

merged 30 commits into from
Mar 17, 2023

Conversation

fabriciojs
Copy link
Member

@fabriciojs fabriciojs commented Dec 26, 2022

Description

Preparing kool v2.0.

  • Removed deprecated features.
  • Introducing the kool cloud subcommand umbrella.
  • Adding Kool Cloud Deploy documentation.
  • Adding new kool deploy setup command.
  • Cloud deploy config validator.
  • kool create becomes interactive when no arguments are supplied.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Patch coverage: 19.38% and project coverage change: -4.72 ⚠️

Comparison is base (8a08010) 79.34% compared to head (6d3c0c2) 74.62%.

❗ Current head 6d3c0c2 differs from pull request most recent head d956537. Consider uploading reports for the commit d956537 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   79.34%   74.62%   -4.72%     
==========================================
  Files          72       75       +3     
  Lines        2702     2901     +199     
==========================================
+ Hits         2144     2165      +21     
- Misses        499      674     +175     
- Partials       59       62       +3     
Impacted Files Coverage Δ
commands/cloud_deploy_destroy.go 100.00% <ø> (ø)
commands/cloud_deploy_exec.go 95.91% <ø> (ø)
commands/cloud_deploy_logs.go 100.00% <ø> (ø)
core/shell/prompt_input.go 0.00% <0.00%> (ø)
services/compose/consolidated_compose.go 0.00% <0.00%> (ø)
commands/recipe.go 34.00% <9.52%> (-17.62%) ⬇️
commands/cloud_setup.go 11.88% <11.88%> (ø)
commands/create.go 60.86% <26.66%> (-27.77%) ⬇️
commands/cloud.go 100.00% <100.00%> (ø)
commands/cloud_deploy.go 31.49% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fabriciojs fabriciojs marked this pull request as ready for review December 27, 2022 20:08
# Applications usually will require a special image built for deployment.
build: Dockerfile

# Tells Kool Cloud that this service is accessible through the deployment URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size of container and daemons are missing, no mention of variables...

# The Deploy API will get the contents of this file and make all of them available
# as true environment variables for the container. You can check them in your deployed
# container via kool cloud exec env (assuming you have env available).
environment: kool.deploy.env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to fix this before launch environment and env... it's very confusing...

Comment on lines +31 to +35
* [kool cloud deploy](kool_cloud_deploy) - Deploy a local application to a Kool Cloud environment
* [kool cloud destroy](kool_cloud_destroy) - Destroy an environment deployed to Kool Cloud
* [kool cloud exec](kool_cloud_exec) - Execute a command inside a running service container deployed to Kool Cloud
* [kool cloud logs](kool_cloud_logs) - See the logs of running service container deployed to Kool Cloud
* [kool cloud setup](kool_cloud_setup) - Set up local configuration files for deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these doc files are missing

@fabriciojs fabriciojs added release-drafter:major Release drafter: Major release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:documentation Release drafter: Documentation labels Mar 17, 2023
@fabriciojs fabriciojs merged commit 9c66a1e into main Mar 17, 2023
@fabriciojs fabriciojs deleted the 2.0 branch March 17, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:documentation Release drafter: Documentation release-drafter:major Release drafter: Major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants