Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kool start error message improv + verbose output improvement #483

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

fabriciojs
Copy link
Member

@fabriciojs fabriciojs commented Oct 30, 2023

Issue #279
🧰 Improvement Yes
📖 Documentation No
⚠️ Break Change No

Description

  • kool start - improved error message when no docker-compose.yml or else designated docker compose config file not found in the current working dir;
  • improve the output of actual commands when using --verbose

Notes

  • Other suggestions on the ticket don't seem to be worth the trade-off at this point - because handling more errors would mean wrapping the output file pointers to some sort of buffer to be able to check it later, but that would cause for losing TTY capacity when using interactive - something we don't want.

@github-actions github-actions bot added release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (852c3f0) 73.21% compared to head (881ff30) 73.23%.

❗ Current head 881ff30 differs from pull request most recent head 89195e6. Consider uploading reports for the commit 89195e6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   73.21%   73.23%   +0.01%     
==========================================
  Files          75       75              
  Lines        2972     2974       +2     
==========================================
+ Hits         2176     2178       +2     
+ Misses        727      725       -2     
- Partials       69       71       +2     
Files Coverage Δ
commands/start.go 92.30% <0.00%> (-2.43%) ⬇️
core/shell/shell.go 80.00% <50.00%> (+1.48%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit 95c3927 into main Nov 4, 2023
9 checks passed
@fabriciojs fabriciojs deleted the errors-handling branch November 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants