Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to kool cloud setup #484

Merged
merged 7 commits into from Nov 15, 2023
Merged

fixes to kool cloud setup #484

merged 7 commits into from Nov 15, 2023

Conversation

fabriciojs
Copy link
Member

Issue -
🪲 Bug Fix Yes
❌ Removed No
⚠️ Break Change No

Description

Several fixes and improvements to kool cloud setup

@github-actions github-actions bot added release-drafter:fixed Release drafter: Fixed release-drafter:patch Release drafter: Patch labels Nov 7, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (bc42b16) 73.23% compared to head (e6f6211) 73.01%.

❗ Current head e6f6211 differs from pull request most recent head e83f537. Consider uploading reports for the commit e83f537 to get more accurate results

Files Patch % Lines
commands/cloud_setup.go 3.65% 79 Missing ⚠️
commands/cloud_deploy.go 66.66% 2 Missing ⚠️
core/shell/prompt_select.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
- Coverage   73.23%   73.01%   -0.23%     
==========================================
  Files          75       75              
  Lines        2974     3005      +31     
==========================================
+ Hits         2178     2194      +16     
- Misses        725      741      +16     
+ Partials       71       70       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit df31408 into main Nov 15, 2023
9 checks passed
@fabriciojs fabriciojs deleted the deploy-setup-fixes branch November 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-drafter:fixed Release drafter: Fixed release-drafter:patch Release drafter: Patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants