New version of server.js doesn't work with iisnode

[sirws]

I just installed the latest version of koop-sample-app and put it in my iis server with iisnode. I get an internal server error.

If I change this line:
http.createServer(app).listen(config.server.port);
to
http.createServer(app).listen(process.env.PORT || config.server.port);

It works. Is there a reason this was taken out server.js? It was there before. Thanks!

[sirws]

@chelm Is there any issue updating this in the master so I don't have to modify it every time there is an update?

[jgravois]

that should be fine. can you PR it? if not, I can.

[chelm]

👍

[sirws]

#10

[ungoldman]

config.server.port shouldn't be standard anyway as that's something that should be determined at the app (express) level not the middleware (koop) level.

[chelm]

@ngoldman yes and its only used at the app level. That can and should be removed in favor of env.PORT - but also do we have apps default to a port? I guess that'd be no different than having the config default to a port, so... word.

[ungoldman]

I believe this is resolved, closing. Thanks for the PR @sirws 👍

[mhogeweg]

new to koop/node.js. not seeing http.createServer(app).listen(config.server.port); in the server.js file in the sample app I just cloned. should the sample app install documentation be updated?

[sirws]

@mhogeweg I think their fix means you can skip that step. I would give it a shot without making that fix. I will try it later myself with the new server.js and make sure it doesn't break anything. I don't think it will based on looking at it.

[jgravois]

we now set the port here