Feature/streaming insert #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfenton
force-pushed
the
feature/streaming-insert
branch
from
7c8577a
to
ccf9847
Compare
| }, function (err, rowCount) { | ||
| if (err) { | ||
| // set status to failed | ||
| return |
There was a problem hiding this comment.
What's the appropriate thing to do here? This is hanging the response when this request fails.
There was a problem hiding this comment.
@dmfenton I dont know enough about all the changes to understand but I'll pull it down in a bit an look and we hang to talk about it.
|
Still need to rebuild the check cache method and add some tests. |
added 7 commits
June 7, 2015 11:59
make togeojson async again add missing module fix typo
dmfenton
force-pushed
the
feature/streaming-insert
branch
from
ba084ed
to
88aceec
Compare
|
I'll merge it cause its pretty awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #31
Resolves #20
Resolves #9