Feature / Use AST to translate WHERE clause #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work! I'm sure it's going to work, but will you add in a test case for the specific issue that kicked this off? |
|
I mean a test specifically for the bug in: https://esriarlington.tpondemand.com/entity/81713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will parse the input WHERE clause into AST, instead of doing regex matching, and traverse the tree to generate translated clause. Not many comments are added since the implementation is very straightforwards. No regex hack :-)
From what I can tell from the test running, the speed is the same.
This PR has covered the problem at #53.