Make changes to datasets explicit in JSONL diffs #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, JSONL diffs just output feature and meta items that had changed. Then we added "metaInfo" messages to output schema.json meta items even when they haven't changed - to give the client the necessary context to output features that have changed. This change adds two new message types: - "dataset" messages to output when entire datasets have changed (ie, they are added or removed - anything else isn't a dataset change but is a smaller change that we already output as a feature or meta change) - "datasetInfo" messages which are output when datasets have *not* changed, but provide extra context - that there is a dataset at a particular path, its type (eg "table" or "point-cloud") and its version.
olsen232
force-pushed
the
explicit-dataset-diffs
branch
from
4fedfc1
to
434c887
Compare
craigds
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, JSONL diffs just output feature and meta items that had
changed.
Then we added "metaInfo" messages to output schema.json meta items even
when they haven't changed - to give the client the necessary context to
output features that have changed.
This change adds two new message types:
changed (ie, they are added or removed - anything else isn't a dataset
change but is a smaller change that we already output as a feature or
meta change)
changed, but provide extra context - that there is a dataset at a
particular path, its type (eg "table" or "point-cloud") and its version.
Related links:
#565