Support shell detection in helper mode #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure shellingham.posix is included in packages - dump traceback for unhandled errors when running under helper
rcoup
requested changes
Aug 24, 2022
- remove debug - print traceback to stderr - guard against KeyError in default shell detection
|
Updating for merge of tab completion install being its own command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shell detection in for command completion installation goes through a few hoops to determine the correct shell. If it can't, in this case due to double forking and detaching in the background of the helper if will fail.
Additionally shellingham.posix was not being picked up by the pyinstaller build.
Dump traceback for unhandled errors when running under helper
Related links:
https://github.com/sarugaku/shellingham#notes-for-application-developers
Checklist: