Use tqdm for better progress reporting during WC checkout #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsen232
force-pushed
the
wc-progress-reporting
branch
from
9998e19
to
a177d48
Compare
craigds
approved these changes
Nov 28, 2022
olsen232
force-pushed
the
wc-progress-reporting
branch
from
a177d48
to
75d78e8
Compare
|
Setting ncols to a maximum is not done - currently, setting this explicitly seems to ruin tqdm's smart sizing (whereby it will make a smaller progress bar and cut out some cruft if the window is small). We can maybe get this fixed in tqdm one day, otherwise, current behaviour is better even if the progress bars look a bit extreme on a widescreen. |
olsen232
force-pushed
the
wc-progress-reporting
branch
from
75d78e8
to
cf22793
Compare
|
ok 👍 |
olsen232
force-pushed
the
wc-progress-reporting
branch
from
cf22793
to
13c5ffc
Compare
Consistent, used for both vector and PC checkout, has some nice features: - don't need to explicitly log every 10th or 10,000th feature - tqdm decides. - logs to stderr, but keeps it brief if it is not isatty() - draws a nice progress bar Note that setting KART_SHOW_PROGRESS=1 will force it to output - useful for clients running Kart as a subprocess that want to report progress. Still TODO: use tqdm during clone and fetch operations too
olsen232
force-pushed
the
wc-progress-reporting
branch
from
13c5ffc
to
bd2c253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent, used for both vector and PC checkout, has some nice features:
Still TODO, one day maybe: use tqdm during clone and fetch operations too