Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch crs84Extent to a 4-point-polygon #809

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Switch crs84Extent to a 4-point-polygon #809

merged 1 commit into from
Mar 28, 2023

Conversation

olsen232
Copy link
Collaborator

Description

Switch from an axis-aligned extent for the crs84Extent field for point clouds:
crs84Extent = 174.73844833207193,174.74945404214898,-36.85123712200056,-36.84206322341377,-1.66,99.83
to a 4 point polygon (ie, a rectangle or similar, but no longer axis-aligned):
POLYGON((174.7384483 -36.8512371,174.7382443 -36.8422277,174.7494540 -36.8420632,174.7496594 -36.8510726,174.7384483 -36.8512371))

Lots of tile hashes have changed due to re-import of the test datasets, which was done as the simplest way to update the tile metadata in line with the new spec - but re-importing with convert-to-copc isn't deterministic and so the tile hashes have all changed.

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

@olsen232 olsen232 merged commit a2bde9e into master Mar 28, 2023
@olsen232 olsen232 deleted the fix-crs84extent branch March 28, 2023 01:24
@rcoup
Copy link
Member

rcoup commented Mar 29, 2023

if you have a point cloud dataset that you already created, it will still have the old style value in that field. and it will stay like that forever until and unless you reimport or otherwise update the tiles in some way. In Kart terms that's compatible since Kart doesn't actually use the field for anything, it just exposes it to the user / client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants