Add multi-worker support for tile import. #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affects both point cloud and raster tile import. Doesn't affect diffing or committing.. Resurrected existing (deprecated) option --num-processes, but made it an alias for the preferred name: --num-workers.
olsen232
force-pushed
the
parallelize-tile-imports
branch
from
905111a
to
3a6ed60
Compare
craigds
approved these changes
Apr 13, 2023
kart/tile/importer.py
Outdated
|
|
||
| def get_default_num_workers(self): | ||
| num_workers = get_num_available_cores() | ||
| click.echo(num_workers) |
There was a problem hiding this comment.
Suggested change
| click.echo(num_workers) |
kart/tile/importer.py
Outdated
| num_workers = 1 | ||
| elif num_workers > self.MAX_WORKERS: | ||
| raise click.UsageError( | ||
| f"Importing with more than {self.MAX_WORKERS} workers is not supported" |
There was a problem hiding this comment.
why? this was here for the old v2 tabular import code because each process handled one dest subtree, but it doesn't seem like it makes sense for tile-based imports
There was a problem hiding this comment.
Removed arbitrary MAX_WORKERS limit
| @@ -524,6 +572,25 @@ def import_tiles_to_stream(self, stream, sources): | |||
|
|
|||
| p.update(1) | |||
|
|
|||
| def copy_multiple_files_to_lfs_cache(self, copy_and_convert_tasks): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects both point cloud and raster tile import.
Doesn't affect diffing or committing..
Resurrected existing (deprecated) option --num-processes, but made it an alias for the preferred name: --num-workers.
Checklist: