Faster diffs: Don't always run pygit2.Tree.diff_tree #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't run it when the user requests the diff of a particular feature - we can look up the feature for both revs quicker than pygit2 can find all diffs in the entire revision.
olsen232
force-pushed
the
quicker-diffs
branch
from
5c2a536
to
6bd4dc5
Compare
craigds
approved these changes
Jan 31, 2024
kart/dataset_mixins.py
Outdated
| @@ -160,6 +166,66 @@ def get_decoder(dataset, method_name): | |||
| _INSERT_UPDATE = _INSERT_TYPES + _UPDATE_TYPES | |||
| _UPDATE_DELETE = _UPDATE_TYPES + _DELETE_TYPES | |||
|
|
|||
| def get_raw_deltas_for_keys( | |||
| self, other, key_encoder_method, key_filter, reverse=False | |||
There was a problem hiding this comment.
type hints on args wouldn't go amiss, the names don't make them very obvious
(we should probably be moving towards type hints everywhere)
There was a problem hiding this comment.
Done - added type hints to this file
tests/test_diff.py
Outdated
| ): | ||
| def _get_raw_diff_for_subtree(self, *args, **kwargs): | ||
| # When only nz_pa_points_topo_150k:1182 is requested, a different more efficient code-path should be used. | ||
| raise AssertionError( |
There was a problem hiding this comment.
Suggested change
| raise AssertionError( | |
| pytest.fail( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run it when the user requests the diff of a particular feature
There will be an extremely great speedup in the extreme case where the user wants to see a single feature that has changed, across a revision-range where a million features have changed.
If the user requests enough features, eventually there will be a crossover where this code path is slower. Eg if the user requests to see more features than have actually changed. However, mostly the size of the list of features requested will be much smaller than the size of the layer / size of the changes.
Checklist: